Skip to content

ZEPPELIN-1311. Typo in ZEPPELIN-1197 #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zjffdu wants to merge 1 commit into from
Closed

ZEPPELIN-1311. Typo in ZEPPELIN-1197 #1307

zjffdu wants to merge 1 commit into from

Conversation

@zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Aug 9, 2016

What is this PR for?

My bad, it should be Exception rather than Execution

2016-08-09_1528

What type of PR is it?

[Bug Fix]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

Tested manually.

Screenshots (if appropriate)

Here's the new log after this fix.
image

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@zjffdu
Copy link
Contributor Author

zjffdu commented Aug 9, 2016

\cc @Leemoonsoo @minahlee Is it possible to merge it into 0.6.1 ?

@minahlee
Copy link
Member

minahlee commented Aug 9, 2016 •
edited
Loading

@zjffdu Thanks for the fix. Let me merge it as hotfix

@zjffdu
Copy link
Contributor Author

zjffdu commented Aug 9, 2016

Thanks @minahlee, the CI fail should be irrelevant, it is due to network issue.

[INFO] └── semver-utils@1.1.1
[ERROR] npm ERR! Linux 3.13.0-40-generic
[ERROR] npm ERR! argv "/home/travis/build/apache/zeppelin/zeppelin-web/node/node" "/home/travis/build/apache/zeppelin/zeppelin-web/node/node_modules/npm/bin/npm-cli.js" "install" "--color=false"
[ERROR] npm ERR! node v0.12.13
[ERROR] npm ERR! npm  v2.15.0
[ERROR] 
[ERROR] npm ERR! Callback called more than once.
[ERROR] npm ERR! 
[ERROR] npm ERR! If you need help, you may report this error at:
[ERROR] npm ERR!     <https://github.com/npm/npm/issues>
[ERROR] 
[ERROR] npm ERR! Please include the following file with any support request:
[ERROR] npm ERR!     /home/travis/build/apache/zeppelin/zeppelin-web/npm-debug.log

@zjffdu
Copy link
Contributor Author

zjffdu commented Aug 9, 2016

@minahlee Please hold the commit, I will have another improvement soon.

@zjffdu
Copy link
Contributor Author

zjffdu commented Aug 9, 2016

Done, now it would print the full stack stace
image

@minahlee
Copy link
Member

minahlee commented Aug 9, 2016

Change looks good to me. Merging to master and branch-0.6

@bzz
Copy link
Member

bzz commented Aug 9, 2016

Looks great to me

@asfgit asfgit closed this in 4178089 Aug 9, 2016
@minahlee
Copy link
Member

minahlee commented Aug 9, 2016

@zjffdu While I am merging this guy, I realized that this fix is not applicable to branch-0.6 since #1232 is only merged to master. For me, #1232 seems more like improvement than bug fix. It would be nice if we can provide same feature for python interpreter at the same release for user experience consistency. I am suggesting to keep #1232, #1307 only master and provide it in next release. What do you think?

@zjffdu
Copy link
Contributor Author

zjffdu commented Aug 9, 2016

oh, sorry, I didn't realize ZEPPELIN-1197 is not in 0.6. Then let's merge this to master only.

asfgit pushed a commit that referenced this pull request Aug 10, 2016
@zjffdu @minahlee
ZEPPELIN-1311. Typo in ZEPPELIN-1197
144c2fb 
### What is this PR for?
My bad, it should be `Exception` rather than `Execution`

![2016-08-09_1528](https://cloud.githubusercontent.com/assets/164491/17508482/aab4fe8c-5e47-11e6-9e26-1295b76cd43b.png)

### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1311

### How should this be tested?
Tested manually.

### Screenshots (if appropriate)
Here's the new log after this fix.
![image](https://cloud.githubusercontent.com/assets/164491/17508506/c5798ca6-5e47-11e6-9f91-e827116dcf38.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <zjffdu@apache.org>

Closes #1307 from zjffdu/ZEPPELIN-1311 and squashes the following commits:

e289c58 [Jeff Zhang] ZEPPELIN-1311. Typo in ZEPPELIN-1197

(cherry picked from commit 4178089)
Signed-off-by: Mina Lee <minalee@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zjffdu @minahlee @bzz